Skip to content

feat(OAuth2API): add revokeToken method #10440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Aug 20, 2024
Merged

feat(OAuth2API): add revokeToken method #10440

merged 8 commits into from
Aug 20, 2024

Conversation

Larsundso
Copy link
Contributor

@Larsundso Larsundso commented Aug 9, 2024 •
edited by almeidx
Loading

Please describe the changes this PR makes and why it should be merged:
This change completes the OAuth2 Authorization flow by supporting the Token Revocation URL

Fixes #10439

This PR relies on:

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)

@Larsundso Larsundso requested a review from a team as a code owner August 9, 2024 11:30
@vercel Vercel
Copy link

vercel bot commented Aug 9, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Aug 20, 2024 8:57am
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Aug 20, 2024 8:57am

almeidx
almeidx requested changes Aug 17, 2024
View reviewed changes
Copy link
Member

@almeidx almeidx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The linter is going to fail here. You should run pnpm fmt

@almeidx almeidx changed the title feat(OAuth2API): add 'revokeToken' method feat(OAuth2API): add revokeToken method Aug 17, 2024
@almeidx almeidx added this to the core 1.3.0 milestone Aug 17, 2024
@almeidx almeidx mentioned this pull request Aug 17, 2024
Merged
kyranet
kyranet requested changes Aug 19, 2024
View reviewed changes
Copy link
Member

@kyranet kyranet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One little nitpick

@vladfrangu vladfrangu requested a review from kyranet August 19, 2024 16:03
@kodiakhq kodiakhq bot merged commit 69adc6f into discordjs:main Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@didinele didinele didinele left review comments

@kyranet kyranet kyranet approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

@almeidx almeidx almeidx approved these changes

@vladfrangu vladfrangu Awaiting requested review from vladfrangu vladfrangu is a code owner automatically assigned from discordjs/core

@iCrawl iCrawl Awaiting requested review from iCrawl iCrawl is a code owner automatically assigned from discordjs/core

Assignees

No one assigned

Labels

packages:core semver:minor

Projects

discord.js
Archived in project

Milestone

core 1.3.0

Development

Successfully merging this pull request may close these issues.

OAuth2 method for token revoke endpoint

5 participants

@Larsundso @kyranet @SpaceEEC @didinele @almeidx