Skip to content

fix(PollAnswer): fetchVoters route changed to MessageManager #10251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 4, 2024
Merged

fix(PollAnswer): fetchVoters route changed to MessageManager #10251

merged 1 commit into from
May 4, 2024

Conversation

XCraftTM
Copy link
Contributor

@XCraftTM XCraftTM commented May 4, 2024

Please describe the changes this PR makes and why it should be merged:
Poll.fetchVoters() function was throwing error cause it used the Channel Internally, so i changed to use the MessageManager Instead.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@XCraftTM XCraftTM requested a review from a team as a code owner May 4, 2024 20:35
@vercel Vercel
Copy link

vercel bot commented May 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview May 4, 2024 8:35pm
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview May 4, 2024 8:35pm

@Jiralite Jiralite added this to the discord.js 14.15.2 milestone May 4, 2024
@Jiralite Jiralite changed the title fix(PollAnswer): fetchVoters changed to MessageManager fix(PollAnswer): fetchVoters route changed to MessageManager May 4, 2024
@kodiakhq kodiakhq bot merged commit 30d79e8 into discordjs:main May 4, 2024
@XCraftTM XCraftTM deleted the patch-1 branch May 4, 2024 21:27
@AlexEKinney AlexEKinney mentioned this pull request May 26, 2024
Open
@User5029 User5029 mentioned this pull request May 26, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request May 26, 2024
Open
@whizbangpop whizbangpop mentioned this pull request May 26, 2024
Open
@colehammond65 colehammond65 mentioned this pull request May 26, 2024
Merged
@Azzraya Azzraya mentioned this pull request May 27, 2024
Open
@JajoScript JajoScript mentioned this pull request May 27, 2024
Merged
@The0mikkel The0mikkel mentioned this pull request May 28, 2024
Closed
@User5029 User5029 mentioned this pull request May 29, 2024
Open
@ImPabl0 ImPabl0 mentioned this pull request May 30, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request May 30, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request May 30, 2024
Open
@Azzraya Azzraya mentioned this pull request Jun 1, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Jun 1, 2024
Open
@Azzraya Azzraya mentioned this pull request Aug 15, 2024
Open
This was referenced Aug 15, 2024
Open
Open
@AlexEKinney AlexEKinney mentioned this pull request Aug 18, 2024
Open
@Azzraya Azzraya mentioned this pull request Aug 18, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Aug 19, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Aug 19, 2024
Open
@Azzraya Azzraya mentioned this pull request Aug 19, 2024
Open
@mezotv mezotv mentioned this pull request Aug 19, 2024
Closed
@HowlingArcher HowlingArcher mentioned this pull request Aug 20, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Aug 20, 2024
Open
@Azzraya Azzraya mentioned this pull request Aug 20, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Aug 21, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Aug 21, 2024
Open
@Azzraya Azzraya mentioned this pull request Aug 21, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Aug 22, 2024
Open
@MinhhTien MinhhTien mentioned this pull request Aug 22, 2024
Closed
@whizbangpop whizbangpop mentioned this pull request Aug 22, 2024
Open
@Azzraya Azzraya mentioned this pull request Aug 22, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Aug 22, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Aug 28, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Aug 28, 2024
Open
@Azzraya Azzraya mentioned this pull request Aug 28, 2024
Open
This was referenced Aug 30, 2024
Open
Open
@jshuntley jshuntley mentioned this pull request Sep 1, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Sep 2, 2024
Open
@jshuntley jshuntley mentioned this pull request Sep 2, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Sep 2, 2024
Open
@Azzraya Azzraya mentioned this pull request Sep 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vladfrangu vladfrangu vladfrangu approved these changes

@Jiralite Jiralite Jiralite approved these changes

@almeidx almeidx almeidx approved these changes

@iCrawl iCrawl Awaiting requested review from iCrawl iCrawl is a code owner automatically assigned from discordjs/core

@kyranet kyranet Awaiting requested review from kyranet kyranet is a code owner automatically assigned from discordjs/core

@SpaceEEC SpaceEEC Awaiting requested review from SpaceEEC SpaceEEC is a code owner automatically assigned from discordjs/core

Assignees

No one assigned

Labels

packages:discord.js semver:patch

Projects

discord.js
Archived in project

Milestone

discord.js 14.15.2

Development

Successfully merging this pull request may close these issues.

4 participants

@XCraftTM @vladfrangu @Jiralite @almeidx