Skip to content

types: generic for Webhook type #10188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 31, 2024
Merged

types: generic for Webhook type #10188

merged 4 commits into from
Mar 31, 2024

Conversation

Qjuh
Copy link
Member

@Qjuh Qjuh commented Mar 23, 2024

Please describe the changes this PR makes and why it should be merged:

Introduce a type parameter Webhook<Type extends WebhookType> that determines the type of Webhook to correclty narrow its properties. The typeguard methods of Webhook now use this type parameter.

Resolves #9182

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@Qjuh Qjuh requested a review from a team as a code owner March 23, 2024 12:48
@vercel Vercel
Copy link

vercel bot commented Mar 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Mar 31, 2024 2:10pm
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Mar 31, 2024 2:10pm

@Jiralite Jiralite added this to the discord.js 14.15 milestone Mar 23, 2024
@kodiakhq kodiakhq bot merged commit 980a2b7 into discordjs:main Mar 31, 2024
@Qjuh Qjuh deleted the types/webhook branch April 15, 2024 18:44
@whizbangpop whizbangpop mentioned this pull request May 25, 2024
Open
@RobinSquared RobinSquared mentioned this pull request May 25, 2024
Closed
@HowlingArcher HowlingArcher mentioned this pull request May 25, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request May 25, 2024
Open
@User5029 User5029 mentioned this pull request May 26, 2024
Open
@StrezlessMusick StrezlessMusick mentioned this pull request May 26, 2024
Open
@The0mikkel The0mikkel mentioned this pull request May 26, 2024
Closed
@Azzraya Azzraya mentioned this pull request May 26, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request May 26, 2024
Open
@User5029 User5029 mentioned this pull request May 26, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request May 26, 2024
Open
@ZeroXClem ZeroXClem mentioned this pull request Aug 12, 2024
Closed
@AlexEKinney AlexEKinney mentioned this pull request Aug 15, 2024
Open
@Azzraya Azzraya mentioned this pull request Aug 15, 2024
Open
This was referenced Aug 15, 2024
Open
Open
@AlexEKinney AlexEKinney mentioned this pull request Aug 18, 2024
Open
@Azzraya Azzraya mentioned this pull request Aug 18, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Aug 19, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Aug 19, 2024
Open
@Azzraya Azzraya mentioned this pull request Aug 19, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Aug 20, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Aug 20, 2024
Open
@Azzraya Azzraya mentioned this pull request Aug 20, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Aug 21, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Aug 21, 2024
Open
@Azzraya Azzraya mentioned this pull request Aug 21, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Aug 22, 2024
Open
@whizbangpop whizbangpop mentioned this pull request Aug 22, 2024
Open
@Azzraya Azzraya mentioned this pull request Aug 22, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Aug 22, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Aug 28, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Aug 28, 2024
Open
@Azzraya Azzraya mentioned this pull request Aug 28, 2024
Open
This was referenced Aug 30, 2024
Open
Open
@jshuntley jshuntley mentioned this pull request Sep 1, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Sep 2, 2024
Open
@jshuntley jshuntley mentioned this pull request Sep 2, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Sep 2, 2024
Open
@Azzraya Azzraya mentioned this pull request Sep 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl iCrawl approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

@kyranet kyranet Awaiting requested review from kyranet kyranet is a code owner automatically assigned from discordjs/core

Assignees

No one assigned

Labels

packages:discord.js semver:patch typings

Projects

discord.js
Archived in project

Milestone

discord.js 14.15

Development

Successfully merging this pull request may close these issues.

typings(webhooks): Incoming webhook

5 participants

@Qjuh @vladfrangu @iCrawl @SpaceEEC @Jiralite