Skip to content

fix: replace internal calls to Emoji#url #10025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 3, 2023
Merged

fix: replace internal calls to Emoji#url #10025

merged 1 commit into from
Dec 3, 2023

Conversation

monbrey
Copy link
Member

@monbrey monbrey commented Dec 3, 2023 •
edited
Loading

Fixes #10024

  • I know how to update typings and have done so, or typings don't need updating

@monbrey monbrey requested a review from a team as a code owner December 3, 2023 22:43
@vercel Vercel
Copy link

vercel bot commented Dec 3, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Dec 3, 2023 10:43pm
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Dec 3, 2023 10:43pm

@Jiralite Jiralite added this to the discord.js 14.15 milestone Dec 3, 2023
@kodiakhq kodiakhq bot merged commit 941642a into discordjs:main Dec 3, 2023
@whizbangpop whizbangpop mentioned this pull request May 25, 2024
Open
@RobinSquared RobinSquared mentioned this pull request May 25, 2024
Closed
@HowlingArcher HowlingArcher mentioned this pull request May 25, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request May 25, 2024
Open
@User5029 User5029 mentioned this pull request May 26, 2024
Open
@StrezlessMusick StrezlessMusick mentioned this pull request May 26, 2024
Open
@The0mikkel The0mikkel mentioned this pull request May 26, 2024
Closed
@Azzraya Azzraya mentioned this pull request May 26, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request May 26, 2024
Open
@User5029 User5029 mentioned this pull request May 26, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request May 26, 2024
Open
@whizbangpop whizbangpop mentioned this pull request May 26, 2024
Open
@colehammond65 colehammond65 mentioned this pull request May 26, 2024
Merged
@Azzraya Azzraya mentioned this pull request May 27, 2024
Open
@The0mikkel The0mikkel mentioned this pull request May 28, 2024
Closed
@User5029 User5029 mentioned this pull request May 29, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Aug 15, 2024
Open
@Azzraya Azzraya mentioned this pull request Aug 15, 2024
Open
This was referenced Aug 15, 2024
Open
Open
@AlexEKinney AlexEKinney mentioned this pull request Aug 18, 2024
Open
@Azzraya Azzraya mentioned this pull request Aug 18, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Aug 19, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Aug 19, 2024
Open
@Azzraya Azzraya mentioned this pull request Aug 19, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Aug 20, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Aug 20, 2024
Open
@Azzraya Azzraya mentioned this pull request Aug 20, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Aug 21, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Aug 21, 2024
Open
@Azzraya Azzraya mentioned this pull request Aug 21, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Aug 22, 2024
Open
@whizbangpop whizbangpop mentioned this pull request Aug 22, 2024
Open
@Azzraya Azzraya mentioned this pull request Aug 22, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Aug 22, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Aug 28, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Aug 28, 2024
Open
@Azzraya Azzraya mentioned this pull request Aug 28, 2024
Open
This was referenced Aug 30, 2024
Open
Open
@jshuntley jshuntley mentioned this pull request Sep 1, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Sep 2, 2024
Open
@jshuntley jshuntley mentioned this pull request Sep 2, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Sep 2, 2024
Open
@Azzraya Azzraya mentioned this pull request Sep 2, 2024
Open
@monbrey monbrey deleted the fix/emoji-url branch September 12, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vladfrangu vladfrangu vladfrangu approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

@Jiralite Jiralite Jiralite approved these changes

@iCrawl iCrawl Awaiting requested review from iCrawl iCrawl is a code owner automatically assigned from discordjs/core

@kyranet kyranet Awaiting requested review from kyranet kyranet is a code owner automatically assigned from discordjs/core

Assignees

No one assigned

Labels

packages:discord.js semver:patch

Projects

discord.js
Archived in project

Milestone

discord.js 14.15

Development

Successfully merging this pull request may close these issues.

The Emoji#url getter is deprecated. Use Emoji#imageURL() instead.

4 participants

@monbrey @vladfrangu @SpaceEEC @Jiralite