Make the PROMPT_COMMAND chain with existing #157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Hi, @aJanuary. You've made a good work here! Thank you so much for your contribution. I'd ask you just to change de version.sh file and the CHANGELOG.md according to the CONTRIBUTING.md |
If something else has already set the PROMPT_COMMAND (for example, ghostty or mise), currently the themes will clobber the existing value, breaking their functionality. This patch adds `;$PROMPT_COMMAND` to the end, so that bash will execute the existing commands as well.
aJanuary
force-pushed
the
play-well-with-others
branch
from
985e590 to
7c29d10
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If something else has already set the PROMPT_COMMAND (for example, ghostty or mise), currently the themes will clobber the existing value, breaking their functionality.
This patch adds
;$PROMPT_COMMANDto the end, so that bash will execute the existing commands as well.