Add Laravel 9 Support #90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there anything missing before this gets merged? |
|
@specialtactics could you add an update regarding this PR? It's the only one missing to be merged to add official laravel-9 support for dingo at api-ecosystem-for-laravel/dingo-api#18 |
|
@specialtactics Hi, is possible to merge this PR for have a full laravel 9 support of dingo-api. Please |
Member
|
Hey guys, sorry for the delay - was on holidays. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@specialtactics Ran tests locally with Laravel 9 on PHP 8 Successfully.
Once this is merged and tagged, I should be able to produce a Laravel 9 PR for https://github.com/api-ecosystem-for-laravel/dingo-api ❤️