Bug/fix potential use after free #2676
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is basically #2663 but targeting the master branch
As concequence this means we cannot just call
sqlite3_column_name
inField::field_name()
. To fix this issue I decided to get all columnnames pointers once after calling
step()
the first time and cache themas part of the specific Statement instance. This introduces a lot of
lifetimes to be very explicit about what is valid for which time.