Skip to content

Update ExternalAuthButton.tsx #737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 3, 2025
Merged

Update ExternalAuthButton.tsx #737

merged 2 commits into from
Mar 3, 2025

Conversation

Madelyyn
Copy link
Contributor

@Madelyyn Madelyyn commented Mar 3, 2025

Update button text to "Continue with {provider}" to reflect both sign-in and sign-up functionality.

Update button text to "Continue with Discord" to reflect both sign-in and sign-up functionality.
Copy link
Owner

@diced diced left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch, "continue with" does sound better in this context

@diced
Copy link
Owner

diced commented Mar 3, 2025

no idea why the action is being dumb here 😭

@diced diced merged commit a3aa130 into diced:trunk Mar 3, 2025
0 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants