Add exists conditional modifier to date, fix parser regex #666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…it the same as istrue but inverting the true/false strings
|
not sure why it includes the commits of the previous merged pr tbh |
before this fix, here `{file.createdAt::locale::it-IT,Europe/Rome}{file.id}` it would matcg `it-IT,Europe/Rome}{file.id` as locale timezone
here `{file.name::exists["yes"||"no"]}{file.originalName::exists["yes"||"no"]}` it would match `yes"||"no"]}{file.originalName::exists["yes"||"no` as `mod_check_true` group
Stef-00012
changed the title
diced
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since i noticed that
{file.deletesAt}can benull, I added::existsmodifier todates tooalso fixed parser regex, before this fix, here
{file.createdAt::locale::it-IT,Europe/Rome}{file.id}it would matchit-IT,Europe/Rome}{file.idas locale timezonehere
{file.name::exists["yes"||"no"]}{file.originalName::exists["yes"||"no"]}it would match"yes"||"no"]}{file.originalName::exists["yes"asmod_check_truegroupdocs pr at diced/zipline-docs#79