text_render: Support per-glyph overrides #8182
Merged
+70
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, an override font had to contain all the 256 glyphs in the row that it was overriding. Experiments have shown that this would cause huge file increase in CJK scripts (+200MiB or so). Instead, allows the override font to only override some glyphs in a row. For all glyphs (sprites) that have width 0, we now fall back to the base font.
AJenbo
approved these changes
Sep 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, an override font had to contain all the 256 glyphs in the row that it was overriding. Experiments have shown that this would cause huge file increase in locale-specific (#3538) CJK fonts (+200MiB or so).
Instead, allows the override font to only override some glyphs in a row.
For all glyphs (sprites) that have width 0, we now fall back to the base font.