Fix Error for Unique Monsters with Indices > 127 #8177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ces greater than 127
glebm
approved these changes
Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unique monster IDs are stored in a uint8_t, which means that we should be able to have up to 254 unique monsters (ID 255 is reserved for representing the monster having no unique monster ID). However, because two lines in the code cast the unique monster ID to an int8_t, we get errors for unique monsters with ID beyond 127.
This PR fixes that, by changing those casts, so that we properly support unique monster indices from 127-254, almost doubling the amount of unique monster indices available for modding.