Parse Text/Speech Data from TSV #8138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glebm
reviewed
Aug 22, 2025
Source/textdat.cpp
Outdated
Comment on lines
85
to
87
| while ((pos = speech.txtstr.find("\\n", pos)) != std::string::npos) { | ||
| speech.txtstr.replace(pos, 2, "\n"); | ||
| pos += 1; |
There was a problem hiding this comment.
This loop is quadratic, can you please make it linear? This can be easily done by appending to a separate string rather than doing it in-place.
yuripourre
reviewed
Aug 22, 2025
There was a problem hiding this comment.
Thank you for keeping this! ❤️
There was a problem hiding this comment.
This file is a much better way to keep it as well
There was a problem hiding this comment.
Yeah, I thought it was important to preserve information :) and I saw that effects-unused.tsv existed, so I followed the existing pattern
AJenbo
reviewed
Aug 23, 2025
Andrettin
commented
Aug 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves text/speech data to a TSV file.