Skip to content

chore: delete nix/emscripten-fix.patch #5485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 16, 2025
Merged

chore: delete nix/emscripten-fix.patch #5485

merged 2 commits into from
Sep 16, 2025

Conversation

ggreif
Copy link
Contributor

@ggreif ggreif commented Sep 15, 2025

No description provided.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 15, 2025 •
edited
Loading

Comparing from 744aceb to 54a531d:
The produced WebAssembly code seems to be completely unchanged.
In terms of gas, no changes are observed in 5 tests.
In terms of size, no changes are observed in 5 tests.

@ggreif ggreif marked this pull request as ready for review September 15, 2025 10:27
@ggreif ggreif requested a review from a team as a code owner September 15, 2025 10:27
@ggreif ggreif self-assigned this Sep 15, 2025
@ggreif ggreif added the automerge-squash When ready, merge (using squash) label Sep 15, 2025
@christoph-dfinity
Copy link
Contributor

Is there anything I need to verify other than CI passing here?

@ggreif
Copy link
Contributor Author

ggreif commented Sep 16, 2025

Is there anything I need to verify other than CI passing here?

I don't think so. We used to build RTS with a modified emscripten, but now cargo can build it.

@mergify mergify bot merged commit 1a981cc into master Sep 16, 2025
26 checks passed
@mergify mergify bot deleted the gabor/del branch September 16, 2025 07:55
@mergify mergify bot removed the automerge-squash When ready, merge (using squash) label Sep 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christoph-dfinity christoph-dfinity christoph-dfinity approved these changes

Assignees

@ggreif ggreif

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ggreif @christoph-dfinity