Skip to content

Conversation

NikolaMilosa
Copy link
Contributor

This PR adds just the call to the registry canister from ic-admin. At the moment the feature is turned off so this will be erroring out.

@github-actions github-actions bot added the feat label Sep 1, 2025
@NikolaMilosa NikolaMilosa marked this pull request as ready for review September 1, 2025 13:45
@NikolaMilosa NikolaMilosa requested a review from a team as a code owner September 1, 2025 13:45
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request changes code owned by the Governance team.
Therefore, make sure that you have done the following (for
Governance-owned code):

  1. Add entry(s) to corresponding unreleased_changelog.md
    file(s). This is only necessary if the code changes result in
    externally visible behavior changes.

  2. If there are behavior changes, are they breaking? This is
    usually due to some new requirement(s) imposed by the canister,
    or removal of guarantees supplied by the canister. If the
    changes are breaking, are your clients ready for them? If not,
    put your changes behind a "feature flag". If you have a feature
    flag, then, do NOT add entrie(s) to unreleased_changelog.md
    in this PR, but rather, do that later when you set the flag to
    "enable" in another PR.

  3. Is data migration needed? (If so, make sure it is part of this
    PR.)

  4. Does this require security review? At the very least, you can
    tell security team about this PR, and let them decide whether
    the risk warrants their review.

To acknowldge this reminder (and unblock the PR), dismiss this
code review by going to the bottom of the pull request page, look
for where it says this bot is requesting changes, click the three
dots on the right, select "Dismiss review", and for each of the
numbered items listed above, supply one of the following reasons:

  • Done.

  • $REASON_WHY_NO_NEED. E.g. for unreleased_changelog.md, "No
    canister behavior changes.", or for item 2, "Existing APIs
    behave as before.".

To be more precise, "externally visible behavior change" usually
means that responses differ in some way. However, "externally
visible behavior change" is not limited to that. For example, it
could also means that the canister makes different requests to
other canisters.

For a more comprehensive checklist, see here.

GOVERNANCE_CHECKLIST_REMINDER_DEDUP

@NikolaMilosa NikolaMilosa dismissed github-actions[bot]’s stale review September 1, 2025 13:48
  1. Done
  2. No breaking changes
  3. No migration needed
  4. Done
@NikolaMilosa NikolaMilosa added this pull request to the merge queue Sep 2, 2025
Merged via the queue into master with commit 039a1ac Sep 2, 2025
28 checks passed
@NikolaMilosa NikolaMilosa deleted the nim-ic-admin-swaps-call branch September 2, 2025 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants