refactor(nns): Delete ManageNeuronResponse from governance.proto. #3573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le to delete ManageNeuron though, because it is used by ProposalData, which is DEFINITELY stored in stable memory.
daniel-wong-dfinity-org
force-pushed
the
delete-manage-neuron-from-governance-proto-daniel-wong
branch
from
66a5042 to
4af389d
Compare
There was a problem hiding this comment.
diff reading guide.
(Remarks from the previous PR's reading guide also apply here.)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
If this pull request affects the behavior of any canister owned by
the Governance team, remember to update the corresponding
unreleased_changes.md file(s).
To acknowldge this reminder (and unblock the PR), dismiss this
code review by going to the bottom of the pull request page, and
supply one of the following reasons:
-
Done.
-
No canister behavior changes.
daniel-wong-dfinity-org
dismissed
github-actions[bot]’s stale review
This is a refactor; hence, no canister behavior changes.
max-dfinity
approved these changes
Jan 22, 2025
daniel-wong-dfinity-org
deleted the
delete-manage-neuron-from-governance-proto-daniel-wong
branch
This was referenced Jan 23, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 29, 2025
Recently, we deleted a bunch of request and response types from NNS governance.proto. Although the types themselves are not necessary, the comments contained valuable information, which could (and should) have been copied to governance.did. This PR corrects that oversight. # References Types deleted in recent PRs: * [ListNeurons] * [ManageNeuronResponse] * [NeuronInfo] [ListNeurons]: #3546 [ManageNeuronResponse]: #3573 [NeuronInfo]: #3639
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea here is very much the same as the previous PR in this thread/series. Therefore, please see the description of the aforementioned PR for an overview, and details.
One difference here is that we only deleted the response type, not the request type. In this case, deleting the request type is not possible, because it is used (indirectly) by
Governance(viaProposal). This is an unusual situation; most request types do not have this property.