feat: initial draft of custom metric tool and its systemd timer #1963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankdavid
approved these changes
Oct 10, 2024
ic-os/components/monitoring/custom-metrics/metrics_tool.service
Outdated
Show resolved
Hide resolved
nabdullindfinity
force-pushed
the
na/interrupts-collector
branch
from
787788d to
3c302a0
Compare
nmattia
pushed a commit
that referenced
this pull request
Oct 25, 2024
To support the performance monitoring on mainnet, add a tool where custom metrics can be calculated and exported to prometheus's `node_exporter` through the `textfile` collector. Currently, the total number of TLB shootdowns across all CPUs will be exposed as `sum_tlb_shootdowns`, collected once per minute, as the latest `node_exporter` does not allow filtering of data of its built-in `interrupts` collector that could otherwise do it for us (until prometheus/node_exporter#3028 is included in the release branches) and will add many metrics with high cardinality otherwise. NODE-1445
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support the performance monitoring on mainnet, add a tool where custom metrics can be calculated and exported to prometheus's
node_exporterthrough thetextfilecollector.Currently, the total number of TLB shootdowns across all CPUs will be exposed as
sum_tlb_shootdowns, collected once per minute, as the latestnode_exporterdoes not allow filtering of data of its built-ininterruptscollector that could otherwise do it for us (until prometheus/node_exporter#3028 is included in the release branches) and will add many metrics with high cardinality otherwise.NODE-1445