fix(markdown): preserve SVG tags in code blocks #707
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-merge-queue bot
pushed a commit
to dfinity/nns-dapp
that referenced
this pull request
Aug 29, 2025
# Motivation dfinity/gix-components#707 fixed an issue on how `svg` are render as part of code blocks in the Markdown component. This issue has arisen with the II proposal that was rendered incorrectly in the nns-dapp, causing problems when attempting to validate the payload. * https://dashboard.internetcomputer.org/proposal/138188 * https://nns.ic0.app/proposal/?u=qoctq-giaaa-aaaaa-aaaea-cai&proposal=138188 This PR fixes it as shown in the following screenshot: <img width="809" height="633" alt="Screenshot 2025-08-29 at 11 25 39" src="https://github.com/user-attachments/assets/37bf5cad-b56a-4a36-8e3e-65f4d4b80cc9" /> [NNS1-4082](https://dfinity.atlassian.net/browse/NNS1-4082) # Changes - Bump gix to latest. # Tests - Validate the payload with the new rendering output and getting `1c18791e243e9c00cfb124320df7b11a216660cf9f9616a39e8565f62f3a2236` [NNS1-4082]: https://dfinity.atlassian.net/browse/NNS1-4082?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
Markdowncomponent converts markdown into HTML. For security reasons, the input is sanitized before transformation.The initial implementation was introduced here and acknowledged this edge case.
We need to address this use case now, as there is a mismatch between how the proposal is rendered and how it should be rendered:
Changes
Screenshots