Skip to content

Conversation

@AntonioVentilii
Copy link
Contributor

Motivation

We receive some warnings from SASS new version:

DEPRECATION WARNING: Sass's behavior for declarations that appear after nested
rules will be changing to match the behavior specified by CSS in an upcoming
version. To keep the existing behavior, move the declaration above the nested
rule. To opt into the new behavior, wrap the declaration in `& {}`.

More info: https://sass-lang.com/d/mixed-decls

   ┌──> src/lib/styles/mixins/_layout.scss
23 │     box-sizing: border-box;
   │     ^^^^^^^^^^^^^^^^^^^^^^ declaration

   ┌──> src/lib/styles/mixins/_media.scss
17 │ ┌     @media (min-width: $breakpoint-medium) {
18 │ │       @content;
19 │ │     }
   │ └─── nested rule

    src/lib/styles/mixins/_layout.scss 23:3                          content()
    src/lib/components/SplitContent.svelte.vite-preprocess.scss 9:5  root stylesheet

DEPRECATION WARNING: Sass's behavior for declarations that appear after nested
rules will be changing to match the behavior specified by CSS in an upcoming
version. To keep the existing behavior, move the declaration above the nested
rule. To opt into the new behavior, wrap the declaration in `& {}`.

More info: https://sass-lang.com/d/mixed-decls

   ┌──> src/lib/styles/mixins/_layout.scss
25 │     padding-top: 0;
   │     ^^^^^^^^^^^^^^ declaration
   ╵
   ┌──> src/lib/styles/mixins/_media.scss
17 │ ┌     @media (min-width: $breakpoint-medium) {
18 │ │       @content;
19 │ │     }
   │ └─── nested rule
   ╵
    src/lib/styles/mixins/_layout.scss 25:3                          content()
    src/lib/components/SplitContent.svelte.vite-preprocess.scss 9:5  root stylesheet

DEPRECATION WARNING: Sass's behavior for declarations that appear after nested
rules will be changing to match the behavior specified by CSS in an upcoming
version. To keep the existing behavior, move the declaration above the nested
rule. To opt into the new behavior, wrap the declaration in `& {}`.

More info: https://sass-lang.com/d/mixed-decls

   ┌──> src/lib/styles/mixins/_layout.scss
30 │     padding-bottom: var(--layout-bottom-offset, 0);
   │     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ declaration

   ┌──> src/lib/styles/mixins/_media.scss
17 │ ┌     @media (min-width: $breakpoint-medium) {
18 │ │       @content;
19 │ │     }
   │ └─── nested rule

    src/lib/styles/mixins/_layout.scss 30:3                          content()
    src/lib/components/SplitContent.svelte.vite-preprocess.scss 9:5  root stylesheet

DEPRECATION WARNING: Sass's behavior for declarations that appear after nested
rules will be changing to match the behavior specified by CSS in an upcoming
version. To keep the existing behavior, move the declaration above the nested
rule. To opt into the new behavior, wrap the declaration in `& {}`.

More info: https://sass-lang.com/d/mixed-decls

   ┌──> src/lib/styles/mixins/_layout.scss
33 │     min-width: calc([100](https://github.com/dfinity/gix-components/actions/runs/13236327756/job/36941848570#step:3:101)vw - var(--padding-2x));
   │     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ declaration
   ╵
   ┌──> src/lib/styles/mixins/_media.scss
17 │ ┌     @media (min-width: $breakpoint-medium) {
18 │ │       @content;
19 │ │     }
   │ └─── nested rule
   ╵
    src/lib/styles/mixins/_layout.scss 33:3                          content()
    src/lib/components/SplitContent.svelte.vite-preprocess.scss 9:5  root stylesheet

Changes

Move the nested rule below.

Screenshots

Current tests will suffice.

@AntonioVentilii AntonioVentilii marked this pull request as ready for review February 10, 2025 08:55
@AntonioVentilii AntonioVentilii requested review from a team as code owners February 10, 2025 08:55
Copy link
Member

@peterpeterparker peterpeterparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!!

@AntonioVentilii AntonioVentilii enabled auto-merge (squash) February 10, 2025 10:35
@AntonioVentilii AntonioVentilii merged commit 60b8865 into main Feb 10, 2025
9 checks passed
@AntonioVentilii AntonioVentilii deleted the chore/solve-SAS-warnings branch February 10, 2025 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants