test: e2e infinite scroll #562
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterpeterparker
added a commit
that referenced
this pull request
Jan 22, 2025
# Motivation Without disabling SSR we would not be able to build the showcase case app once the component `InfiniteScroll` is effectively used in the UI. This is because `IntersectionObserver` is not a known NodeJS property. # Notes PR that uses the `InfiniteScroll` in the UI is #562. # Changes - Disable SSR which we do not used in first place anyway - Added wait in the segments E2E as the screenshots seem to be generated earlier following this change (see test https://github.com/dfinity/gix-components/actions/runs/12868805408/job/35876230527) --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
dskloetd
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Given that the
InfiniteScrollcomponent will need some adjustments for compatibility with Svelte v5, I thought it would be a good idea to first add an end-to-end test to verify that the scroll works as expected.Notes
Requires #563 configuration to build the showcase app.
Changes
testIdto the component