Skip to content

Add banner bg variable #557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 23, 2024
Merged

Add banner bg variable #557

merged 1 commit into from
Dec 23, 2024

Conversation

@mstrasinskis
Copy link
Contributor

@mstrasinskis mstrasinskis commented Dec 23, 2024 •
edited
Loading

Motivation

To solve the low contrast of the banners in cards and standardize their appearance, a new color theme variable has been added.

Changes

  • Added --banner-background to both themes.

Screenshots

Before After
image image
image image
image image
image image

@mstrasinskis mstrasinskis marked this pull request as ready for review December 23, 2024 10:02
@mstrasinskis mstrasinskis requested review from a team as code owners December 23, 2024 10:02
yhabib
yhabib approved these changes Dec 23, 2024
View reviewed changes
Copy link
Contributor

@yhabib yhabib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.
We can use it here

@mstrasinskis
Copy link
Contributor Author

Thanks. We can use it here

Correct. And in the other custom implementations.

@mstrasinskis mstrasinskis merged commit 12d5bac into main Dec 23, 2024
9 checks passed
@mstrasinskis mstrasinskis deleted the banner-colour branch December 23, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yhabib yhabib yhabib approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mstrasinskis @yhabib