chore(): update comment #552
Conversation
.github/workflows/checks.yml
Outdated
| # changes and instead just fail if the formatting is incorrect. | ||
| # In order to trigger other workflows after committing docs changes, we need | ||
| # to use the PR Automation App. This token is not available for external | ||
| # contributors. So on forked PRs, we don't commit changes and instead just fail |
There was a problem hiding this comment.
By "forked PR", do you mean a PR created from a fork of the repo?
We used to specifically check if the PR came from a fork of the repo, but this wasn't good enough as discussed here, so we changed it in this PR to just check for the presence of the token instead.
But now you are changing the comment back from being about the presence of the token to about being forked. Do the previous considerations no longer apply?
There was a problem hiding this comment.
Ah wow, good memory! Should i just be very explicit then and say "forked PR or from dependabot"?
There was a problem hiding this comment.
Is dependabot really the only other possibility?
Isn't there another way to do what dependabot does?
Why not just stick with "PRs where the app secret is not available"?
Even though I guessed correctly what was meant by "forked PR", I do find that phrase a bit confusing.
.github/workflows/checks.yml
Outdated
| # changes and instead just fail if the formatting is incorrect. | ||
| # In order to trigger other workflows after committing docs changes, we need | ||
| # to use the PR Automation App. This token is not available for external | ||
| # contributors. So on forked PRs, we don't commit changes and instead just fail |
There was a problem hiding this comment.
Is dependabot really the only other possibility?
Isn't there another way to do what dependabot does?
Why not just stick with "PRs where the app secret is not available"?
Even though I guessed correctly what was meant by "forked PR", I do find that phrase a bit confusing.
2 participants
Motivation
This updates the comment with the currently correct information.
Changes
No code changes, just updating a comment.