chore: update dependencies to allow new canister settings #168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
THLO
reviewed
Nov 18, 2025
cycles-ledger/tests/tests.rs
Outdated
|
|
||
| fn build_wasm(name: &str) -> Vec<u8> { | ||
| if name == "cycles-ledger" { | ||
| if false { |
Contributor
Author
There was a problem hiding this comment.
I need this for local testing and just committed it for the second time 🤦♀️
Contributor
Author
There was a problem hiding this comment.
Also for some reason that is not considered dead code and clippy dosen't complain about it 😞
THLO
approved these changes
Nov 18, 2025
THLO
approved these changes
Nov 19, 2025
lwshang
reviewed
Nov 21, 2025
fake-cmc/src/main.rs
Outdated
| let cycles = msg_cycles_available128(); | ||
| if cycles < 100_000_000_000 { | ||
| let cycles = msg_cycles_available(); | ||
| if cycles < CANISTER_CREATION_FEE { |
Contributor
There was a problem hiding this comment.
The fee used to be 100_000_000_000. It is now changed to CANISTER_CREATION_FEE = 500_000_000_000. Is this change on purpose?
Contributor
Author
There was a problem hiding this comment.
I assumed that value was updated when canister creation fees were updated, but apparently not. I'll revert that
lwshang
approved these changes
Nov 21, 2025
Contributor
lwshang
left a comment
lwshang
left a comment
There was a problem hiding this comment.
LGTM.
The only question was in fake-cmc which is for testing. The logic there was not crucial.
viviveevee
deleted the
SDK-2418-support-new-canister-options-in-cycles-ledger
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow specifying new canister settings on canister creation