fix: removed timeout notification #6760
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prkhrkat
requested review from
vikramdevtron,
nishant-d,
prakarsh-dt and
vivek-devtron
as code owners
Code Review Agent Run #0df612Actionable Suggestions - 0Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help AI Code Review powered by |
|
Changelist by BitoThis pull request implements the following key changes.
|
vikramdevtron
approved these changes
Jul 24, 2025
Ash-exp
added a commit
that referenced
this pull request
Jul 31, 2025
* ephemeral error fix * ephemeral error fix (#6737) * panic fix * NotificationRule removed * vendor update * misc: Added Github Actions for linting and building api specs (#6720) * Added action to check for linting errors in openapi.yaml * Create build-docs.yaml * added read-only permission in api-linter * updated action to add permission * misc: open api spec addition (#6750) * added version yml * changes in openapi.yaml * Updated build-docs.yaml (#6752) switch the approach from rebasing to creating a temp folder and copying the file * misc: fixing swagger openapi.yaml (#6751) * resolved application.yaml * resolved application.yaml * resolved applisting.yaml * resolved charts.yaml helm-apps list * resolved jobs.yaml jobs list * removed unrequired server * renamed the x-displayName * resolved app-labels.yaml * resolved merge-conflict * resolved merge-conflict - 02 * added Get Deployment History (ENT) spec * misc: adding codeowner for swagger api spec (#6754) * adding codeowner for swagger api spec * adding codeowner for swagger api spec * gitops validation spec added (#6755) * misc: Update openapi spec (#6758) * Updated openapi-spec with notificats api * updated openapi-spec to add historical-get-api-change * updated the title of openapi specs (#6759) * removed timeout notification (#6760) * misc: Timeout main notification (#6761) * removed timeout notification * removed timeout notification * misc: changes in description of api spec (#6767) * changes in description of api spec * refactor: rename bulk edit config SQL files for consistency * chore: update dependencies to origin/main --------- Co-authored-by: prakhar katiyar <[email protected]> Co-authored-by: prakhar katiyar <[email protected]> Co-authored-by: ayushmaheshwari <[email protected]> Co-authored-by: iamayushm <[email protected]> Co-authored-by: Vikram <[email protected]> Co-authored-by: Vikram Singh <[email protected]> Co-authored-by: akshatsinha007 <[email protected]> Co-authored-by: kamal-devtron <[email protected]> Co-authored-by: Badal Kumar <[email protected]> Co-authored-by: Pawan Kumar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes https://github.com/devtron-labs/sprint-tasks/issues/2500
Checklist:
Does this PR introduce a user-facing change?
Summary by Bito
This PR removes timeout notification logic from the workflow status service by deleting the timeout condition check and associated asynchronous CD notification calls. The change simplifies event handling and eliminates redundant code, directly addressing the referenced bug.