Skip to content

fix: app status filter for not deployed #5971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

Shivam-nagar23
Copy link
Member

Description

Fixes #

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


Copy link

gitguardian bot commented Oct 8, 2024

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@Shivam-nagar23 Shivam-nagar23 changed the base branch from main to release-candidate-v0.20.0 October 8, 2024 12:35
Copy link

sonarqubecloud bot commented Oct 8, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
8.4% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@Shivam-nagar23 Shivam-nagar23 merged commit b5382eb into release-candidate-v0.20.0 Oct 8, 2024
7 of 10 checks passed
@Shivam-nagar23 Shivam-nagar23 deleted the fix-app-status-filter branch October 8, 2024 12:47
vikramdevtron added a commit that referenced this pull request Oct 14, 2024
* initialise acd client (#5964)

* auth group fix (#5966)

* query params append fix (#5967)

* bluk edit cm and secret fix (#5968)

* removed the field cia (#5969)

* query fix (#5971)

* rollback fix (#5972)

* fix: copy container image version

* fix: cluster and env prod/non prod not propagated in notification event payload

* common-lib update

* error handling while creating github repo (#5978)

---------

Co-authored-by: ayu-devtron <[email protected]>
Co-authored-by: Shivam Nagar <[email protected]>
Co-authored-by: Prakash <[email protected]>
Co-authored-by: Rajeev Ranjan <[email protected]>
Co-authored-by: Ash-exp <[email protected]>
Co-authored-by: Gireesh Naidu <[email protected]>
Co-authored-by: Gireesh Naidu <[email protected]>
Co-authored-by: prakhar katiyar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants