Minor improvements and improved compatibility with SDK pack #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Causes PackFolder=tool in nugetizer. Fixes #131
SDK Pack always packs tools as framework-specific, so we default to doing the same. Fixes #132 tools
We used to perform no path normalization in the AssignPackagePath task, and this meant we could easily end with mixed paths, making it difficult to tell apart which are the same, and when comparing via code, having to take into account the possibility that there might be a mixture. To simplify things, we now normalize all paths to use the / forward slash which is more compatible for cross-platform projects, is already supported universally in MSBuild as well as NuGet, and entirely avoids having to do \\ double slashes for escaping (or @ literals) in code. Fixes #135
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.