Skip to content

Conversation

rauhs
Copy link
Contributor

@rauhs rauhs commented Jul 10, 2023

Fixes #1350.

@stakx
Copy link
Contributor

stakx commented Jul 20, 2023

Thanks for suggesting a fix. Let's wait with a possible merge until we've actually looked at the problem first (see my first comment over in the issue.)

@kzu
Copy link
Member

kzu commented Aug 4, 2023

Could you please rebase on top of main? There were some fixes there. Thanks!

@rauhs rauhs closed this Aug 5, 2023
@rauhs rauhs reopened this Aug 6, 2023
@rauhs
Copy link
Contributor Author

rauhs commented Aug 6, 2023

Could you please rebase on top of main? There were some fixes there. Thanks!

Sorry for the closing/opening. Had a little struggle with git. We're still using svn at $dayjob.

Should be fine now.

@CLAassistant
Copy link

CLAassistant commented Aug 6, 2023

CLA assistant check
All committers have signed the CLA.

@rauhs
Copy link
Contributor Author

rauhs commented Aug 8, 2023

Any help (i.e. just merge this PR and fix any style changes afterwards) would be highly appreciated. I spend about 5x the time on fighting git than on finding+fixing the actual issue :)

FWIW (and not going to send a PR for this). The following would be good for the editorconfig:

trim_trailing_whitespace = true
csharp_space_before_new_parentheses = false

@rauhs
Copy link
Contributor Author

rauhs commented Aug 9, 2023

@kzu Would love to get this PR merged. Any blockers I need to resolve?

@kzu
Copy link
Member

kzu commented Aug 16, 2023

Running the checks now!

Copy link
Contributor

@stakx stakx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@kzu kzu merged commit 1c27e24 into devlooped:main Aug 16, 2023
@devlooped devlooped locked and limited conversation to collaborators Sep 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Performance issue with large interfaces

5 participants