chore(kubernetes): Add helm chart support for extraVolumes and extraVolumeMounts. #114
+56
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pantierra
changed the title
batpad
approved these changes
Dec 16, 2025
Member
|
This seems like exactly what we need for IFRC as well - @sunu would be great to get a quick 👀 from you to confirm - but @pantierra not a blocker to merge - this PR itself seems very straightforward. |
sunu
approved these changes
Dec 18, 2025
Member
sunu
left a comment
sunu
left a comment
There was a problem hiding this comment.
Yes, this is perfect and exactly what we need for IFRC. Thanks @pantierra!
Member
|
@pantierra do you want to go ahead and squash merge this? |
alukach
changed the title
Member
|
Not sure we need to bump the version as this doesn't affect any release necessarily, correct? |
Contributor
Author
|
Right, we will need a new helm chart release to be able to use the changes in deployments. Bumped the version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows mounting custom filters in a kubernetes setup.
Precondition for developmentseed/eoapi-k8s#388
Related: EOEPCA/resource-discovery#198 and IFRCGo/go-deploy#144