Add SSR Support #40
Open
Add SSR Support #40
+8,433
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added `jsdom` as a dependency. In parser-markup.js, `document` is accessed to create a frame to render HTML in. Since `document` doesn't exist in Node, this causes SSR builds to throw a reference error. With this change, we check for the existence of `document` and polyfill it using `jsdom` if it doesn't exist.
|
This is going to inline jsdom in all bundlers. I think we'll need to provide a separate entry module for web/node in order to do the polyfilling. |
|
There are several PR proposals (plus one that was closed without resolution), so I wrote a quick heads-up: #6 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
jsdomas a dependency.In parser-markup.js,
documentis accessed to create a frame to render HTML in. Sincedocumentdoesn't exist in Node, this causes SSR builds to throw a reference error. With this change, we check for the existence ofdocumentand polyfill it usingjsdomif it doesn't exist.