Skip to content

fix: "Property X will overwrite the base property in Y" typescript error #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: "Property X will overwrite the base property in Y" typescript error #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
caccd22
Fix errors
GoogleFeud Jun 24, 2021
e6538d2
Use 'declare' instead of removing the field completely
GoogleFeud Jun 24, 2021
e2075a0
Merge branch 'detritusjs:master' into master
GoogleFeud Oct 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/structures/channel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -886,7 +886,7 @@ export class ChannelDM extends ChannelBase {
readonly _keys = keysChannelDm;
type = ChannelTypes.DM;

lastMessageId?: null | string;
declare lastMessageId?: null | string;

constructor(
client: ShardClient,
Expand Down Expand Up @@ -1022,7 +1022,7 @@ export class ChannelDMGroup extends ChannelDM {
readonly _keys = keysChannelDmGroup;
type = ChannelTypes.GROUP_DM;

applicationId?: string;
declare applicationId?: string;
icon: null | string = null;
ownerId: string = '';

Expand Down Expand Up @@ -1641,11 +1641,11 @@ export class ChannelGuildThread extends ChannelGuildBase {
readonly _keys = keysChannelGuildThread;
type = ChannelTypes.GUILD_PUBLIC_THREAD;

member?: ThreadMember;
declare member?: ThreadMember;
memberCount: number = 0;
messageCount: number = 0;
ownerId: string = '';
threadMetadata!: ThreadMetadata;
declare threadMetadata: ThreadMetadata;

constructor(
client: ShardClient,
Expand Down
2 changes: 1 addition & 1 deletion src/structures/member.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ export class Member extends UserMixin {
nick: null | string = null;
pending: boolean = false;
premiumSinceUnix: number = 0;
user!: User;
declare user: User;

constructor(
client: ShardClient,
Expand Down
2 changes: 1 addition & 1 deletion src/structures/team.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ export class TeamMember extends UserMixin {
membershipState: TeamMembershipStates = TeamMembershipStates.BASE;
permissions!: BaseSet<string>;
teamId: string = '';
user!: User;
declare user: User;

constructor(
client: ShardClient,
Expand Down