Skip to content

Conversation

@gt2345
Copy link
Contributor

@gt2345 gt2345 commented Oct 23, 2024

Ticket

MD-530

Description

Fix an issue preventing deleting experiment with profiling enabled.

Test Plan

Create an experiment with profiling, one example is to change determined/examples/tutorials/mnist_pytorch/train.py to add profiling_enabled:

trainer.fit(max_length=max_length, latest_checkpoint=latest_checkpoint, profiling_enabled=True)

Verify that "Profiler" tab for that experiment in the Web UI exists with value.
Delete the experiment, the experiment should eventually disappear with no error.

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@gt2345 gt2345 requested a review from a team as a code owner October 23, 2024 22:21
@gt2345 gt2345 requested a review from kkunapuli October 23, 2024 22:21
@cla-bot cla-bot bot added the cla-signed label Oct 23, 2024
@codecov
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.47%. Comparing base (e7186fe) to head (c663340).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10113      +/-   ##
==========================================
- Coverage   54.47%   54.47%   -0.01%     
==========================================
  Files        1267     1267              
  Lines      159439   159439              
  Branches     3637     3638       +1     
==========================================
- Hits        86854    86851       -3     
- Misses      72452    72455       +3     
  Partials      133      133              
Flag Coverage Δ
backend 45.66% <ø> (-0.01%) ⬇️
harness 72.55% <ø> (ø)
web 54.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

@netlify
Copy link

netlify bot commented Oct 23, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit c663340
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/671976f0ec90a200088854f1

Copy link
Contributor

@azhou-determined azhou-determined left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! 🔥

@gt2345 gt2345 merged commit e834302 into main Oct 24, 2024
91 of 103 checks passed
@gt2345 gt2345 deleted the gt/530-system-metrics-del-casc branch October 24, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants