chore: create TokenCreator role with permissions to VIEW / CREATE / REVOKE own access tokens
#10064
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oke own access tokens
ShreyaLnuHpe
requested review from
jesse-amano-hpe
and removed request for
a team
ShreyaLnuHpe
requested review from
a team and
corban-beaird
and removed request for
jesse-amano-hpe
ShreyaLnuHpe
changed the title
TokenCreator role with permissions to VIEW / CREATE / Rev…TokenCreator role with permissions to VIEW / CREATE / REVOKE own access tokens
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## shreya/createTable #10064 +/- ##
======================================================
- Coverage 54.39% 51.25% -3.14%
======================================================
Files 1268 716 -552
Lines 159301 103697 -55604
Branches 3631 3632 +1
======================================================
- Hits 86649 53155 -33494
+ Misses 72518 50408 -22110
Partials 134 134
Flags with carried forward coverage won't be shown. Click here to find out more. |
corban-beaird
approved these changes
Oct 15, 2024
Contributor
corban-beaird
left a comment
corban-beaird
left a comment
There was a problem hiding this comment.
Migration looks solid!
Do we want to include a release note/doc update in this PR for this new role?
tara-hpe
reviewed
Oct 17, 2024
docs/manage/security/rbac.rst
Outdated
| ``TokenCreator`` | ||
| ================ | ||
|
|
||
| The ``TokenCreator`` grants the permissions to create, view, and revoke the user's own access |
Contributor
There was a problem hiding this comment.
Suggested change
| The ``TokenCreator`` grants the permissions to create, view, and revoke the user's own access | |
| The ``TokenCreator`` grants users the ability to create, view, and revoke their own access |
tara-hpe
reviewed
Oct 17, 2024
|
|
||
| **New Features** | ||
|
|
||
| - New RBAC role: Added a new ``TokenCreator`` RBAC role. It grants the permissions to create, view, |
Contributor
There was a problem hiding this comment.
Suggested change
| - New RBAC role: Added a new ``TokenCreator`` RBAC role. It grants the permissions to create, view, | |
| - New RBAC role: Add a ``TokenCreator`` RBAC role, which allows users to create, view, |
tara-hpe
reviewed
Oct 17, 2024
| **New Features** | ||
|
|
||
| - New RBAC role: Added a new ``TokenCreator`` RBAC role. It grants the permissions to create, view, | ||
| and revoke the user's own access tokens. It can only be assigned globally. |
Contributor
There was a problem hiding this comment.
Suggested change
| and revoke the user's own access tokens. It can only be assigned globally. | |
| and revoke their own access tokens. This role can only be assigned globally. |
tara-hpe
approved these changes
Oct 17, 2024
Contributor
tara-hpe
left a comment
tara-hpe
left a comment
There was a problem hiding this comment.
LGTM / added suggestions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Description
Test Plan
Checklist
docs/release-notes/See Release Note for details.