feat: update Datagrid filter to account for reoccuring metadata columns

[thiagodallacqua-hpe]

Ticket

ET-790

Description

Right now, if we have multiple metadata columns with the same name, there's no quick way of knowing of which type each one is while selecting it. This PR intends to add a descriptive text next to duplicate entries for the metadata columns.

Test Plan

• make sure that you have at least one metadata column that is duplicated and of a different type
• go to a experiment list
  • make sure that the grid visualization is enabled
• open the filter
• scroll down for the metadata column options
• verify that the duplicates has a <column_name> <column_type_tag> format

Checklist

• Changes have been manually QA'd
• New features have been approved by the corresponding PM
• User-facing API changes have the "User-facing API Change" label
• Release notes have been added as a separate file under docs/release-notes/
  See Release Note for details.
• Licenses have been included for new code which was copied and/or modified from any external code

[netlify]

✅ Deploy Preview for determined-ui canceled.

Name	Link
🔨 Latest commit	8b26336
🔍 Latest deploy log	https://app.netlify.com/sites/determined-ui/deploys/671924619874f000081a9d33

[codecov]

Codecov Report

Attention: Patch coverage is 72.91667% with 26 lines in your changes missing coverage. Please review.

Project coverage is 50.90%. Comparing base (cbf0bb1) to head (3f3ced0).

Files with missing lines	Patch %	Lines
...c/components/FilterForm/components/FilterField.tsx	37.03%	17 Missing ⚠️
webui/react/src/components/MultiSortMenu.tsx	86.20%	7 Missing and 1 partial ⚠️
webui/react/src/pages/FlatRuns/FlatRuns.tsx	0.00%	1 Missing ⚠️

Additional details and impacted files

@@                Coverage Diff                @@
##           thiago/ET-791   #10046      +/-   ##
=================================================
+ Coverage          50.89%   50.90%   +0.01%     
=================================================
  Files                953      953              
  Lines             130355   130426      +71     
  Branches            3653     3663      +10     
=================================================
+ Hits               66339    66394      +55     
- Misses             63882    63897      +15     
- Partials             134      135       +1     

Flag	Coverage Δ
web	54.35% <72.91%> (+0.02%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
webui/react/src/components/ColumnPickerMenu.tsx	96.01% <100.00%> (ø)
...ui/react/src/components/FilterForm/TableFilter.tsx	80.20% <100.00%> (+0.20%)	⬆️
...omponents/FilterForm/components/FilterFormStore.ts	91.45% <100.00%> (+0.02%)	⬆️
webui/react/src/utils/flatRun.ts	99.24% <100.00%> (+<0.01%)	⬆️
webui/react/src/pages/FlatRuns/FlatRuns.tsx	11.27% <0.00%> (ø)
webui/react/src/components/MultiSortMenu.tsx	88.23% <86.20%> (-0.59%)	⬇️
...c/components/FilterForm/components/FilterField.tsx	57.21% <37.03%> (-0.44%)	⬇️

[keita-determined]

we want to show types in all column names

[keita-determined]

could you double-check the ticket? i think specs around separator etc are not follwoing the ticket description.

[thiagodallacqua-hpe]

@keita-determined it turns out that array-typed columns are banned from the filters

const bannedFilterColumns: Set<string> = useMemo(() => {
    return new Set([...BANNED_FILTER_COLUMNS, ...arrayTypeColumns]);
  }, [arrayTypeColumns]);

i know its banned. but when there are metadata with the same name and different type, the metadata won't display in the filter.

that's fixed 😅

[ashtonG]

update the table filter tests -- it seems that they check the label text and now it's failing.

[thiagodallacqua-hpe]

Closing PR due to company restructuring.