Fix crashes on macOS High Sierra #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables API warnings
…ionsManager GHDesktopNotificationsManager is now available only on macOS 10.14 and later.
sergiou87
commented
Jun 2, 2022
Comment on lines
+23
to
+26
| // Only macOS 10.14 and newer are supported. Since os.release() gives us the | ||
| // Darwin kernel version, it should be a major version of 18 or higher, according | ||
| // to https://en.wikipedia.org/wiki/Darwin_%28operating_system%29#Release_history | ||
| return majorVersion >= 18 |
There was a problem hiding this comment.
I saw on Desktop we use Electron's process.getSystemVersion() instead, but that's not available here. Not sure if there is an alternative to this, but I didn't want to add new dependencies and seems like this check should be reliable enough 🤞
sergiou87
commented
Jun 2, 2022
Comment on lines
+58
to
+66
| // Create the desktop notifications manager only if it's a supported macOS version | ||
| if (@available(macOS 10.14, *)) | ||
| { | ||
| desktopNotificationsManager = [GHDesktopNotificationsManager new]; | ||
| } | ||
| else | ||
| { | ||
| return env.Undefined(); | ||
| } |
There was a problem hiding this comment.
I can't do a if (!@available(...)) { return } because the compiler is not smart enough to understand everything outside the if is safe for 10.14 🤦
sergiou87
changed the title
Merged
This was referenced Jun 2, 2022
tidy-dev
approved these changes
Jun 2, 2022
|
Exactly that, thanks for the quick review! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As an attempt to fix desktop/desktop#14712 this PR encapsulates all usages of the Notifications API inside of
GHDesktopNotificationsManager, which is now used only on macOS 10.14 and newer.I also switched the deployment target to 10.13, in order to get warnings on build time when unavailable APIs are being used.