Correct separation of multiple attributes/resources #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey guys, when I'm using mesos-init-wrapper as it is on Ubuntu(14.04 - upstart), then I can't start the mesos-slave. If we want to use a semicolon for delimiting multiple attributes/resources then we have to put whole argument between quotes, otherwise the second argument (right after the semicolon) is evaluated as a new command by Bash. Another approach to this problem is using a comma instead of semicolon on lines 97 and 105. Then we don't need quotation of whole attributes/resources arguments and it's closer to what the mesos-slave documentation says. Cheers, R.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey guys,
when I'm using mesos-init-wrapper as it is on Ubuntu(14.04 - upstart), then I can't start the mesos-slave.
If we want to use a semicolon for delimiting multiple attributes/resources then we have to put whole argument between quotes, otherwise the second argument (right after the semicolon) is evaluated as a new command by Bash. Another approach to this problem is using a comma instead of semicolon on lines 97 and 105. Then we don't need quotation of whole attributes/resources arguments and it's closer to what the mesos-slave documentation says.
Cheers,
R.