chore: cleanup webdriverjs tests and deps #753
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenmathieson
approved these changes
Jun 15, 2023
This was referenced Jul 26, 2023
This was referenced Aug 24, 2023
This was referenced Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This started out trying to resolve the chromedriver ci dependency issue and then I realized that we didn't even need to use chromedriver in the way the tests were setting it up. Looks like the code was copy / pasted from webdriverio which started a chromedriver instance to run. So I swapped out for actually using selenium webdriver and passed it the chromedriver path.
I also realized we didn't use half the dependencies so got rid of them (
expressslol). Lastly moved creating the server to an before/after as there's no point in recreating it every test.