Skip to content

chore: use updated browser-driver-manager #1080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 35 commits into from
Jun 13, 2024
Merged

chore: use updated browser-driver-manager #1080

Show file tree
Hide file tree
Changes from 15 commits
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
7536629
ci/cd: update tests to use browser-driver-manager
scottmries Jun 7, 2024
7fd4df4
cli: use chromedriver installed from browser-driver-manager
scottmries Jun 7, 2024
f029ab8
wdio: use chromedriver installed from browser-driver-manager
scottmries Jun 7, 2024
47f2648
wdjs: use chromedriver installed from browser-driver-manager
scottmries Jun 7, 2024
5f4964e
deps: update browser-driver-manager to 2.0.0
scottmries Jun 7, 2024
b9b3055
fix: replace chrome import.
scottmries Jun 7, 2024
f7702a0
fix(puppeteer): use BDM Chrome path.
scottmries Jun 7, 2024
ec61c21
remove wdio BDM dependency
scottmries Jun 7, 2024
f7458b5
fix(cli): update error
scottmries Jun 7, 2024
5be22e8
remove npm chromedriver implementation
scottmries Jun 10, 2024
d7b6ef9
docs: add chromedriver installation process to READMEs
scottmries Jun 10, 2024
8e75067
remove CHROME_TEST_PATH usage
scottmries Jun 10, 2024
b8f7ad0
docs(wjs): add chromedriver docs
scottmries Jun 10, 2024
d7f0526
refactor
scottmries Jun 10, 2024
f9339ee
remove only
scottmries Jun 10, 2024
fec1d92
replace bundled chromedriver as fallback
scottmries Jun 11, 2024
d6b3576
use bundled chromedriver for puppeteer
scottmries Jun 11, 2024
7ecf488
wjs: remove chromedriver deps
scottmries Jun 11, 2024
3b83b48
use puppeteer's bundled chrome
scottmries Jun 12, 2024
293b9ac
test
scottmries Jun 12, 2024
937c18c
test
scottmries Jun 12, 2024
427e6ff
revert
scottmries Jun 12, 2024
c097945
revert
scottmries Jun 12, 2024
f2431a4
Revert breaking commits
scottmries Jun 12, 2024
975cc02
wjs: add binary path to chrome test options
scottmries Jun 12, 2024
b16f9d9
wio: add binary path to chrome test options
scottmries Jun 12, 2024
8f34c49
use correct type
scottmries Jun 12, 2024
ae290c7
cli: use CHROME_TEST_PATH if availableand not overridden
scottmries Jun 12, 2024
d76a717
remove noisy BDM --verbose
scottmries Jun 12, 2024
b0666c7
puppeteer: remove chromedriver and path
scottmries Jun 12, 2024
bb5198a
test(cli): test chrome paths
scottmries Jun 13, 2024
11d5f9a
wdio: remove windows path exception
scottmries Jun 13, 2024
92b1a9b
test(wjs): assert CHROME/DRIVER_TEST_PATHs exist
scottmries Jun 13, 2024
e30c519
test(cli): assert CHROME/DRIVER_TEST_PATHs exist
scottmries Jun 13, 2024
3302ffe
test(wio): assert CHROME/DRIVER_TEST_PATHs exist
scottmries Jun 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
- run: npm ci
# HACK: Force a TTY to enable browser-driver-manager to manipulate stdout.
- shell: 'script -q -e -c "bash {0}"'
run: npx browser-driver-manager install chromedriver --verbose
run: npx browser-driver-manager install chrome --verbose
working-directory: packages/puppeteer
- run: npm run build --workspace=packages/puppeteer
- run: npm run coverage --workspace=packages/puppeteer
Expand All @@ -59,7 +59,7 @@ jobs:
- run: npm ci
# HACK: Force a TTY to enable browser-driver-manager to manipulate stdout.
- shell: 'script -q -e -c "bash {0}"'
run: npx browser-driver-manager install chromedriver=125 --verbose
run: npx browser-driver-manager install chrome --verbose
working-directory: packages/cli
- run: npm run coverage --workspace=packages/cli

Expand All @@ -79,7 +79,7 @@ jobs:
- run: npm ci
# HACK: Force a TTY to enable browser-driver-manager to manipulate stdout.
- shell: 'script -q -e -c "bash {0}"'
run: npx browser-driver-manager install chromedriver --verbose
run: npx browser-driver-manager install chrome --verbose
working-directory: packages/webdriverjs
- run: npm run build --workspace=packages/webdriverjs
- run: npm run coverage --workspace=packages/webdriverjs
Expand All @@ -101,7 +101,7 @@ jobs:
- run: npm ci
# HACK: Force a TTY to enable browser-driver-manager to manipulate stdout.
- shell: 'script -q -e -c "bash {0}"'
run: npx browser-driver-manager install chromedriver --verbose
run: npx browser-driver-manager install chrome --verbose
working-directory: packages/webdriverio
- run: npm run build --workspace=packages/webdriverio
- run: npm run coverage --workspace=packages/webdriverio
Expand Down
Loading