Feature - Laravel - Customizable artisan path #4066
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonmedv
requested changes
May 10, 2025
Skullsneeze
force-pushed
the
feature/customizable-artisan-path
branch
from
feac30b to
4b05dd8
Compare
|
Thanks @antonmedv, I agree this is a cleaner solution! I've updated the PR and squashed the commits |
antonmedv
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
With certain setups the default path for artisan does not resolve to the correct directory (eg. monorepo with laravel + another application).
Solution
This PR adds the possibility to set a custom path to
artisan, with a fallback to the default path if no custom path is defined.Notes
This PR is somewhat similar in nature to #3772 but aims to provide an easier way of adjusting the path