Skip to content

Conversation

@jbronder
Copy link
Contributor

@jbronder jbronder commented Mar 5, 2025

This PR adds writeTextFile and writeTextFileSync APIs to @std/fs package. These functions mirror the Deno.writeTextFile and Deno.writeTextFileSync APIs.

Also, the unstable_write_file.ts is added to the doc checker in this PR.

Towards #6255.

@jbronder jbronder requested a review from kt3k as a code owner March 5, 2025 20:56
@github-actions github-actions bot added the fs label Mar 5, 2025
@codecov
Copy link

codecov bot commented Mar 5, 2025

Codecov Report

Attention: Patch coverage is 36.06557% with 39 lines in your changes missing coverage. Please review.

Project coverage is 95.67%. Comparing base (b719b19) to head (9624a11).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
fs/unstable_write_text_file.ts 36.06% 39 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6463      +/-   ##
==========================================
- Coverage   95.77%   95.67%   -0.11%     
==========================================
  Files         574      575       +1     
  Lines       42917    42978      +61     
  Branches     6435     6438       +3     
==========================================
+ Hits        41105    41120      +15     
- Misses       1778     1819      +41     
- Partials       34       39       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@kt3k kt3k merged commit 1dee498 into denoland:main Mar 7, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants