Skip to content

Conversation

@jbronder
Copy link
Contributor

This PR adds mkdir and mkdirSync APIs to the @std/fs package which are intended to mirror Deno.mkdir and Deno.mkdirSync functions.

Towards #6255.

@jbronder jbronder requested a review from kt3k as a code owner February 20, 2025 23:40
@github-actions github-actions bot added the fs label Feb 20, 2025
@codecov
Copy link

codecov bot commented Feb 20, 2025

Codecov Report

Attention: Patch coverage is 54.83871% with 14 lines in your changes missing coverage. Please review.

Project coverage is 96.04%. Comparing base (360851f) to head (88feec9).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
fs/unstable_mkdir.ts 54.83% 14 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6436   +/-   ##
=======================================
  Coverage   96.03%   96.04%           
=======================================
  Files         562      563    +1     
  Lines       42418    42449   +31     
  Branches     6387     6390    +3     
=======================================
+ Hits        40738    40770   +32     
- Misses       1641     1646    +5     
+ Partials       39       33    -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice!

@kt3k kt3k merged commit 71c828a into denoland:main Feb 21, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants