Skip to content

Conversation

@iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Jul 2, 2023

It's worth pushing this before #15 to catch any potential compatibility or performance issues.

@iuioiua
Copy link
Contributor Author

iuioiua commented Jul 2, 2023

Sidenote: how does this remote branch create deployments? I thought this wasn't possible.

@kt3k
Copy link
Member

kt3k commented Jul 3, 2023

examples/import_map.json seems also referenced from deno.json at the root (and it's used by testing)

Sidenote: how does this remote branch create deployments? I thought this wasn't possible.

Preview deployment for pull request is created only when the Deploy project doesn't have any env variable. (It doesn't seem documented though...)

@iuioiua
Copy link
Contributor Author

iuioiua commented Jul 3, 2023

examples/import_map.json seems also referenced from deno.json at the root (and it's used by testing)

Fixed.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt3k kt3k merged commit cb15e96 into denoland:main Jul 4, 2023
@iuioiua
Copy link
Contributor Author

iuioiua commented Jul 4, 2023

Ah, thanks for fixing those mistakes! LOL

@iuioiua iuioiua deleted the update-fresh branch July 4, 2023 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants