This repository was archived by the owner on Jun 13, 2025. It is now read-only.
feat: add workspace jsr pkg resolution #99
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nayeemrmn
approved these changes
Aug 6, 2024
src/workspace/resolver.rs
Outdated
| let mut imports = | ||
| if let Some(serde_json::Value::Object(imports)) = maybe_imports { | ||
| imports | ||
| fn normalize_export_name(sub_path: &str) -> Cow<str> { |
There was a problem hiding this comment.
Oh yeah, can we make this public? https://github.com/denoland/deno/blob/v1.45.5/cli/lsp/jsr.rs#L270-L272
There was a problem hiding this comment.
I'm going to push this down to deno_semver
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved from denoland/deno_graph#509
This is in order to support workspace jsr resolution in deno compile as we don't use deno_graph for that code.
This code living here will make more sense once we rename this repo to deno_workspace.