Skip to content

Conversation

@dsherret
Copy link
Member

@dsherret dsherret commented Oct 2, 2025

This allows changing the error message displayed in Deno for errors by providing a "reason" property when denying a permission.

struct PermissionBrokerResponse {
id: u32,
result: String,
reason: Option<String>,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this name ok?

Example:

{
  "id": 1,
  "result": "deny",
  "reason": "Make sure to enable env var permissions in your user settings."
}

@dsherret dsherret requested a review from nathanwhit October 2, 2025 19:16
Copy link
Member

@nathanwhit nathanwhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsherret dsherret enabled auto-merge (squash) October 2, 2025 19:49
@dsherret dsherret merged commit fb69caf into denoland:main Oct 2, 2025
35 of 36 checks passed
@dsherret dsherret deleted the feat_unstable_support_deny_reason branch October 2, 2025 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants