feat(unstable): support named pipes on Windows for the permission broker #30894
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dsherret
commented
Oct 1, 2025
dsherret
commented
dsherret
commented
Oct 1, 2025
|
|
||
| #[cfg(windows)] | ||
| impl LocalStream { | ||
| fn connect_impl(addr: &OsStr) -> io::Result<Self> { |
littledivy
reviewed
Oct 2, 2025
Comment on lines
+58
to
+83
| // Try to open; if the pipe is busy, wait and retry. | ||
| let handle = loop { | ||
| // SAFETY: WinAPI call | ||
| let h = unsafe { | ||
| CreateFileW( | ||
| wide.as_ptr(), | ||
| FILE_GENERIC_READ | FILE_GENERIC_WRITE, | ||
| 0, // no sharing | ||
| std::ptr::null(), | ||
| OPEN_EXISTING, | ||
| FILE_ATTRIBUTE_NORMAL, // blocking | ||
| std::ptr::null_mut(), | ||
| ) | ||
| }; | ||
| if h != INVALID_HANDLE_VALUE { | ||
| break h; | ||
| } | ||
| let err = io::Error::last_os_error(); | ||
| if err.raw_os_error() == Some(ERROR_PIPE_BUSY as i32) { | ||
| // SAFETY: WinAPI call | ||
| unsafe { WaitNamedPipeW(wide.as_ptr(), NMPWAIT_WAIT_FOREVER) }; | ||
| continue; | ||
| } else { | ||
| return Err(err); | ||
| } | ||
| }; |
There was a problem hiding this comment.
I think you can just WaitNamedPipeW before CreateFileW and remove the loop.
There was a problem hiding this comment.
Apparently this should be left as-is in order to handle race conditions (ex. WaitNamedPipeW succeeds, but then fails for CreateFileW).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.