fix(ext/node): fs.stat and fs.statSync compatibility
#30866
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
approved these changes
Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #30570
This PR tries to reland #30637 that got reverted on #30741 due to test flakiness.
The flakiness comes from the
inoproperty ofDeno.FileInfothat can have abiginttype when serialized from the op function to the JS side. It fails the unit test when{ bigint: false }option is passed that expects all stat properties to be a number. This only happens on asynclstatandstat, not the sync version.This PR ensures that the inode property of
Deno.FileInfois always number instead of bigint.