fix(fetch): handle proxied urls correctly and add test

Cargo.toml

@@ -190,7 +190,7 @@ http_v02 = { package = "http", version = "0.2.9" }
 httparse = "1.8.0"
 hyper = { version = "1.6.0", features = ["full"] }
 hyper-rustls = { version = "0.27.2", default-features = false, features = ["http1", "http2", "tls12", "aws-lc-rs"] }
-hyper-util = { version = "0.1.10", features = ["tokio", "client", "client-legacy", "server", "server-auto"] }
+hyper-util = { version = "0.1.17", features = ["tokio", "client", "client-legacy", "server", "server-auto"] }
 hyper_v014 = { package = "hyper", version = "0.14.26", features = ["runtime", "http1"] }
 idna = "1.0.3"
 ignore = "0.4"

tests/specs/run/all_proxy/__test__.jsonc

@@ -0,0 +1,5 @@
+{
+  "if": "linux",
+  "args": "run -A --unstable-vsock test.ts",
+  "output": "test.out"
+}

tests/specs/run/all_proxy/client.ts

@@ -0,0 +1,8 @@
+async function test(url) {
+  const res = await fetch(url);
+  console.log(res);
+  console.log(await res.text());
+}
+
+await test("http://insecure.invalid");
+await test("https://secure.invalid");

tests/specs/run/all_proxy/test.out

@@ -0,0 +1,33 @@
+Listening on vsock:4294967295:1234567
+Response {
+  body: ReadableStream { locked: false },
+  bodyUsed: false,
+  headers: Headers {
+    "content-length": "24",
+    "content-type": "text/plain;charset=UTF-8",
+    date: "[WILDCARD]",
+    vary: "Accept-Encoding"
+  },
+  ok: true,
+  redirected: false,
+  status: 200,
+  statusText: "OK",
+  url: "http://insecure.invalid/"
+}
+http://insecure.invalid/
+Response {
+  body: ReadableStream { locked: false },
+  bodyUsed: false,
+  headers: Headers {
+    "content-length": "23",
+    "content-type": "text/plain;charset=UTF-8",
+    date: "[WILDCARD]",
+    vary: "Accept-Encoding"
+  },
+  ok: true,
+  redirected: false,
+  status: 200,
+  statusText: "OK",
+  url: "https://secure.invalid/"
+}
+https://secure.invalid/

tests/specs/run/all_proxy/test.ts

@@ -0,0 +1,16 @@
+await using server = Deno.serve({
+  transport: "vsock",
+  cid: -1,
+  port: 1234567,
+}, (req) => {
+  return new Response(req.url);
+});
+
+await new Deno.Command(Deno.execPath(), {
+  args: ["run", "-A", "client.ts"],
+  env: {
+    "ALL_PROXY": "vsock:1:1234567",
+  },
+  stderr: "inherit",
+  stdout: "inherit",
+}).output();

tests/unit/fetch_test.ts

@@ -2364,8 +2364,7 @@ Deno.test(
     const resp1 = await fetch("https://example.com/ping", { client });
     assertEquals(resp1.status, 200);
     assertEquals(resp1.headers.get("content-type"), "text/plain");
-    // TODO(@lucacasonato): should be https://example.com/ping. bug in https://github.com/hyperium/hyper-util/blob/00035bac2da1cfa820eda4db7bf7ddcbd30be3c1/src/client/legacy/client.rs#L915-L917
-    assertEquals(await resp1.text(), "http://example.com/ping");
+    assertEquals(await resp1.text(), "https://example.com/ping");
 
     const resp2 = await fetch("http://localhost:42424/ping", { client });
     assertEquals(resp2.status, 200);