Skip to content

fix: restore Windows debug info #30778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 19, 2025
Merged

fix: restore Windows debug info #30778

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 4 additions & 29 deletions .github/workflows/ci.generate.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -761,7 +761,7 @@ const ci = {
name: "Generate symcache",
if: [
"(matrix.job == 'test' || matrix.job == 'bench') &&",
"matrix.os != 'windows' && matrix.profile == 'release' && (matrix.use_sysroot ||",
"matrix.profile == 'release' && (matrix.use_sysroot ||",
"github.repository == 'denoland/deno')",
].join("\n"),
run: [
Expand Down Expand Up @@ -916,37 +916,14 @@ const ci = {
"Get-FileHash target/release/deno-${{ matrix.arch }}-pc-windows-msvc.zip -Algorithm SHA256 | Format-List > target/release/deno-${{ matrix.arch }}-pc-windows-msvc.zip.sha256sum",
"Compress-Archive -CompressionLevel Optimal -Force -Path target/release/denort.exe -DestinationPath target/release/denort-${{ matrix.arch }}-pc-windows-msvc.zip",
"Get-FileHash target/release/denort-${{ matrix.arch }}-pc-windows-msvc.zip -Algorithm SHA256 | Format-List > target/release/denort-${{ matrix.arch }}-pc-windows-msvc.zip.sha256sum",
// TODO(bartlomieju): fix the regression from V8 upgrade
// https://github.com/denoland/deno/pull/30629
// "target/release/deno.exe -A tools/release/create_symcache.ts target/release/deno-${{ matrix.arch }}-pc-windows-msvc.symcache",
"target/release/deno.exe -A tools/release/create_symcache.ts target/release/deno-${{ matrix.arch }}-pc-windows-msvc.symcache",
].join("\n"),
},
{
name: "Upload canary to dl.deno.land (windows)",
name: "Upload canary to dl.deno.land",
if: [
"matrix.job == 'test' &&",
"matrix.profile == 'release' &&",
"matrix.os == 'windows' &&",
"github.repository == 'denoland/deno' &&",
"github.ref == 'refs/heads/main'",
].join("\n"),
run: [
'gsutil -h "Cache-Control: public, max-age=3600" cp ./target/release/*.zip gs://dl.deno.land/canary/$(git rev-parse HEAD)/',
'gsutil -h "Cache-Control: public, max-age=3600" cp ./target/release/*.sha256sum gs://dl.deno.land/canary/$(git rev-parse HEAD)/',
// TODO(bartlomieju): fix the regression from V8 upgrade
// https://github.com/denoland/deno/pull/30629
// 'gsutil -h "Cache-Control: public, max-age=3600" cp ./target/release/*.symcache gs://dl.deno.land/canary/$(git rev-parse HEAD)/',
"echo ${{ github.sha }} > canary-latest.txt",
'gsutil -h "Cache-Control: no-cache" cp canary-latest.txt gs://dl.deno.land/canary-$(rustc -vV | sed -n "s|host: ||p")-latest.txt',
"rm canary-latest.txt gha-creds-*.json",
].join("\n"),
},
{
name: "Upload canary to dl.deno.land (unix)",
if: [
"matrix.job == 'test' &&",
"matrix.profile == 'release' &&",
"matrix.os != 'windows' &&",
"github.repository == 'denoland/deno' &&",
"github.ref == 'refs/heads/main'",
].join("\n"),
Expand Down Expand Up @@ -1168,9 +1145,7 @@ const ci = {
run: [
'gsutil -h "Cache-Control: public, max-age=3600" cp ./target/release/*.zip gs://dl.deno.land/release/${GITHUB_REF#refs/*/}/',
'gsutil -h "Cache-Control: public, max-age=3600" cp ./target/release/*.sha256sum gs://dl.deno.land/release/${GITHUB_REF#refs/*/}/',
// TODO(bartlomieju): fix the regression from V8 upgrade
// https://github.com/denoland/deno/pull/30629
// 'gsutil -h "Cache-Control: public, max-age=3600" cp ./target/release/*.symcache gs://dl.deno.land/release/${GITHUB_REF#refs/*/}/',
'gsutil -h "Cache-Control: public, max-age=3600" cp ./target/release/*.symcache gs://dl.deno.land/release/${GITHUB_REF#refs/*/}/',
].join("\n"),
},
{
Expand Down
20 changes: 4 additions & 16 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -444,7 +444,7 @@ jobs:
- name: Generate symcache
if: |-
!(matrix.skip) && ((matrix.job == 'test' || matrix.job == 'bench') &&
matrix.os != 'windows' && matrix.profile == 'release' && (matrix.use_sysroot ||
matrix.profile == 'release' && (matrix.use_sysroot ||
github.repository == 'denoland/deno'))
run: |-
target/release/deno -A tools/release/create_symcache.ts ./deno.symcache
Expand Down Expand Up @@ -560,24 +560,11 @@ jobs:
Get-FileHash target/release/deno-${{ matrix.arch }}-pc-windows-msvc.zip -Algorithm SHA256 | Format-List > target/release/deno-${{ matrix.arch }}-pc-windows-msvc.zip.sha256sum
Compress-Archive -CompressionLevel Optimal -Force -Path target/release/denort.exe -DestinationPath target/release/denort-${{ matrix.arch }}-pc-windows-msvc.zip
Get-FileHash target/release/denort-${{ matrix.arch }}-pc-windows-msvc.zip -Algorithm SHA256 | Format-List > target/release/denort-${{ matrix.arch }}-pc-windows-msvc.zip.sha256sum
- name: Upload canary to dl.deno.land (windows)
target/release/deno.exe -A tools/release/create_symcache.ts target/release/deno-${{ matrix.arch }}-pc-windows-msvc.symcache
- name: Upload canary to dl.deno.land
if: |-
!(matrix.skip) && (matrix.job == 'test' &&
matrix.profile == 'release' &&
matrix.os == 'windows' &&
github.repository == 'denoland/deno' &&
github.ref == 'refs/heads/main')
run: |-
gsutil -h "Cache-Control: public, max-age=3600" cp ./target/release/*.zip gs://dl.deno.land/canary/$(git rev-parse HEAD)/
gsutil -h "Cache-Control: public, max-age=3600" cp ./target/release/*.sha256sum gs://dl.deno.land/canary/$(git rev-parse HEAD)/
echo ${{ github.sha }} > canary-latest.txt
gsutil -h "Cache-Control: no-cache" cp canary-latest.txt gs://dl.deno.land/canary-$(rustc -vV | sed -n "s|host: ||p")-latest.txt
rm canary-latest.txt gha-creds-*.json
- name: Upload canary to dl.deno.land (unix)
if: |-
!(matrix.skip) && (matrix.job == 'test' &&
matrix.profile == 'release' &&
matrix.os != 'windows' &&
github.repository == 'denoland/deno' &&
github.ref == 'refs/heads/main')
run: |-
Expand Down Expand Up @@ -730,6 +717,7 @@ jobs:
run: |-
gsutil -h "Cache-Control: public, max-age=3600" cp ./target/release/*.zip gs://dl.deno.land/release/${GITHUB_REF#refs/*/}/
gsutil -h "Cache-Control: public, max-age=3600" cp ./target/release/*.sha256sum gs://dl.deno.land/release/${GITHUB_REF#refs/*/}/
gsutil -h "Cache-Control: public, max-age=3600" cp ./target/release/*.symcache gs://dl.deno.land/release/${GITHUB_REF#refs/*/}/
- name: Create release notes
if: |-
!(matrix.skip) && (matrix.job == 'test' &&
Expand Down
12 changes: 6 additions & 6 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ repository = "https://github.com/denoland/deno"

[workspace.dependencies]
deno_ast = { version = "=0.50.0", features = ["transpiling"] }
deno_core = { version = "0.358.0" }
deno_core = { version = "0.359.0" }

deno_cache_dir = "=0.25.0"
deno_doc = "=0.183.0"
Expand Down
5 changes: 1 addition & 4 deletions tools/release/create_symcache.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,7 @@ import path from "node:path";
let debugFile = Deno.execPath();

if (Deno.build.os === "windows") {
// TODO(bartlomieju): fix the regression from V8 upgrade
// https://github.com/denoland/deno/pull/30629
// debugFile = debugFile.replace(/\.exe$/, ".pdb");
Deno.exit(0);
debugFile = debugFile.replace(/\.exe$/, ".pdb");
} else if (Deno.build.os === "darwin") {
const resolvedPath = Deno.realPathSync(`${debugFile}.dSYM`);
const { name } = path.parse(resolvedPath);
Expand Down
Loading