fix(cli): support data urls in preload by not splitting on comma. #30544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specify multple files separately, `--preload p1.js --preload p2.js` instead of `--preload p1.js,p2.js`. Closes denoland#30543.
lrowe
force-pushed
the
fix-preload-data-url
branch
from
a5a861b to
5607e4b
Compare
dsherret
reviewed
Aug 28, 2025
| "deno", | ||
| "run", | ||
| "--preload", | ||
| "p1.js,./p2.js", |
There was a problem hiding this comment.
Does it still work with multiple preload flags? Ex. --preload p1.js --preload ./p2.js?
There was a problem hiding this comment.
Yes, and there is an existing test for that directly underneath this one.
bartlomieju
approved these changes
Aug 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify multple files separately,
--preload p1.js --preload p2.jsinstead of--preload p1.js,p2.js. Closes #30543.