feat: add tcpBacklog arg to Deno.listen{Tls} and Deno.serve
#30541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
changed the title
backlog arg to Deno.listen{Tls} and Deno.servetcpBacklog arg to Deno.listen{Tls} and Deno.serve
dsherret
reviewed
Aug 27, 2025
| #[serde] addr: IpAddr, | ||
| reuse_port: bool, | ||
| load_balanced: bool, | ||
| tcp_backlog: i32, |
There was a problem hiding this comment.
i32? What happens when this is negative?
There was a problem hiding this comment.
For whatever reason, the libc function itself takes a signed int https://man7.org/linux/man-pages/man2/listen.2.html. As far as I can tell, negative values usually just act like you passed 0.
dsherret
changed the title
tcpBacklog arg to Deno.listen{Tls} and Deno.servetcpBacklog arg to Deno.listen{Tls} and Deno.serve
bartlomieju
added a commit
that referenced
this pull request
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds
tcpBacklogargument toDeno.listen,Deno.listenTlsandDeno.serveAPIs.The argument specifies maximum number of pending connections in the listen queue, and
by default is set to 511. Users that expect huge bursts of traffic can customize this
option to a higher value.
Ref #30471
Closes #30388