fix(bundle): do not error on fallible dynamic imports/requires #30522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| fn esbuild_resolve_error_path( | ||
| error: &esbuild_client::protocol::Message, | ||
| ) -> Option<String> { | ||
| let re = lazy_regex::regex!(r#"^Could not resolve "([^"]+)"#); |
There was a problem hiding this comment.
FYI esbuild has an API that allows you to customize the formatting of its diagnostic logs, see https://esbuild.github.io/api/#format-messages
There was a problem hiding this comment.
From my reading, that lets you give them a Message and then get back a formatted string that matches esbuild's native output formatting. Since we want to do our own output (so that it matches the rest of the CLI) I'm not sure it's useful here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30510
Basically we save the error for later, return
Noneto esbuild. Later when we process esbuild errors, if esbuild failed to resolve the same package then we use our error message instead of esbuild'sAlso this changes how we print out the esbuild errors to include the notes, which can often be useful