Skip to content

fix(types): specify ArrayBuffer as a backing buffer type for TextEncoder.encode() #30434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 2, 2025
+5 −8
Merged

fix(types): specify ArrayBuffer as a backing buffer type for TextEncoder.encode() #30434

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fd991bb
remove duplicate declaration for interface TextEncoder
magurotuna Aug 18, 2025
1021d55
specify buffer type explicitly
magurotuna Aug 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions cli/tsc/dts/lib.deno_web.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,12 +452,6 @@ interface TextEncoderEncodeIntoResult {
written: number;
}

/** @category Encoding */
interface TextEncoder extends TextEncoderCommon {
/** Returns the result of running UTF-8's encoder. */
encode(input?: string): Uint8Array;
encodeInto(input: string, dest: Uint8Array): TextEncoderEncodeIntoResult;
}
Comment on lines -455 to -460
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed this interface because it simply appears to be a duplicate with less document

/**
* Allows you to convert a string into binary data (in the form of a Uint8Array)
* given the encoding.
Expand All @@ -474,10 +468,13 @@ interface TextEncoder extends TextEncoderCommon {
*/
interface TextEncoder extends TextEncoderCommon {
/** Turns a string into binary data (in the form of a Uint8Array) using UTF-8 encoding. */
encode(input?: string): Uint8Array;
encode(input?: string): Uint8Array<ArrayBuffer>;

/** Encodes a string into the destination Uint8Array and returns the result of the encoding. */
encodeInto(input: string, dest: Uint8Array): TextEncoderEncodeIntoResult;
encodeInto(
input: string,
dest: Uint8Array<ArrayBufferLike>,
): TextEncoderEncodeIntoResult;
}

/** @category Encoding */
Expand Down
Loading